fix: prevent API call before backend is fully started #537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengju0213
reviewed
Nov 5, 2025
Collaborator
fengju0213
left a comment
fengju0213
left a comment
There was a problem hiding this comment.
thanks for this pr！ left some comment
| if (isToolInstalled.success) { | ||
| log.info('Tool installed, starting backend service...'); | ||
|
|
||
| // Notify frontend installation success |
Collaborator
There was a problem hiding this comment.
Thanks for the fix! a question though:
Looking at startBackend() in init.ts:209, it resolves as soon as it sees "Uvicorn running on":
if (!started && data.toString().includes("Uvicorn running on")) {
started = true;
resolve(node_process); // Resolves immediately
}There could still be a gap between Uvicorn starting and FastAPI routes being fully loaded. If users submit tasks immediately after installation completes, won't we still hit the race condition from issue #529?
Collaborator
There was a problem hiding this comment.
Should we add a health check poll before notifying the frontend?
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the purpose of this pull request?
close #529